-
Notifications
You must be signed in to change notification settings - Fork 163
Consistently use ycur for user RHS routines
#817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drreynolds
wants to merge
21
commits into
feature/fes-lsrk-cleanup
Choose a base branch
from
feature/fes-ycur-rhs
base: feature/fes-lsrk-cleanup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions on the user-provided yout (== ycur) vector, when possible
Collaborator
Author
|
This is the fourth in a sequence of PRs for ARKODE to support our FES collaborators. Please review this one after #815. When the stack is complete, we'll do a final PR into |
Collaborator
Author
|
This PR should be ready to review -- all CI issues resulting from the new release have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes ARKODE calls to the user-supplied right-hand-side functions so that wherever possible, these RHS calls are provided the user-supplied solution vector that was passed to
ARKodeEvolve.The notable exceptions to this rule are:
However, for most ARKODE integrators is it now possible for users to consistently receive back their own state vector for RHS calls, allowing them to leverage auxiliary data stored therein (e.g., derived quantities or MPI communication buffers).