Skip to content

LSRKStep updates #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drreynolds wants to merge 32 commits into
base: feature/fes-yout-copy
Choose a base branch
from
Open

LSRKStep updates #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
40c1a68
General LSRKStep cleanup, including always using (tcur,ycur) as the c…
drreynolds Jan 16, 2026
df00866
Fixed merge issues
drreynolds Jan 16, 2026
ebc3fa3
Fixed additional merge issues
drreynolds Jan 16, 2026
92f2d94
Ran formatter
drreynolds Jan 16, 2026
eb5b287
Updated logging level 4 output files
drreynolds Jan 16, 2026
b473bd2
Updated logging level 5 output files
drreynolds Jan 16, 2026
0667085
Minor cleanup
drreynolds Jan 16, 2026
c713eca
Updated answers submodule commit
drreynolds Jan 16, 2026
86efcdb
Minor updates
drreynolds Jan 16, 2026
56e99f8
Merge ../fespr2-yout-copy into feature/fes-lsrk-cleanup
drreynolds Jan 16, 2026
5c29828
Updated logging output file
drreynolds Jan 16, 2026
5178c9a
Updated answers submodule commit
drreynolds Jan 16, 2026
15e7078
Merged from feature/fes-yout-copy
drreynolds Jan 26, 2026
3eb8f90
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Jan 27, 2026
bb04638
Removed takestep-specific (tcur,ycur) initialization since it's now i…
drreynolds Jan 27, 2026
ce0468e
Merged with feature/fes-yout-copy
drreynolds Jan 28, 2026
65688a1
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Jan 28, 2026
45ef4ee
Fixed minor differences in .out files for Jenkins
drreynolds Jan 29, 2026
26c7241
Updated answers submodule commit
drreynolds Jan 29, 2026
f497cf7
Updated answers submodule commit
drreynolds Jan 30, 2026
1e31782
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Feb 3, 2026
9015ab5
Updated default numbers of stages for SSP(s,2) and SSP(s,3)
drreynolds Feb 3, 2026
360b360
Updated .out files for SSP(s,2) and SSP(s,3) method now that the defa…
drreynolds Feb 3, 2026
85a9373
Updated answers submodule commit
drreynolds Feb 3, 2026
df32e26
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Feb 3, 2026
9b43da4
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Feb 4, 2026
c042a87
Updated answers submodule commit
drreynolds Feb 4, 2026
1897268
Fixed selection of TakeStep routine for SSPs3 vs SSP43
drreynolds Feb 4, 2026
f4f0512
Ensured that we separately log SSP(s,3) with s=9 and s=4 stages, now …
drreynolds Feb 4, 2026
a6151f4
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Feb 4, 2026
dd181f7
Formatting
drreynolds Feb 4, 2026
ee1d34f
Merge branch 'feature/fes-yout-copy' into feature/fes-lsrk-cleanup
drreynolds Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@

### New Features and Enhancements

The default numbers of stages for the SSP Runge--Kutta methods `ARKODE_LSRK_SSP_S_2`
and `ARKODE_LSRK_SSP_S_3` in LSRKStep were changed from 10 and 9, respectively, to
their minimum allowable values of 2 and 4. Users may revert to the previous values
by calling `LSRKStepSetNumSSPStages`.

### Bug Fixes

### Deprecation Notices
Expand Down
10 changes: 8 additions & 2 deletions doc/arkode/guide/source/Usage/LSRKStep/User_callable.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,13 +387,19 @@ Allowable Method Families
If :c:func:`LSRKStepSetNumSSPStages` is not called, the default ``num_of_stages``
is set. Calling this function with ``num_of_stages <= 0`` resets the default values:

* ``num_of_stages = 10`` for :c:enumerator:`ARKODE_LSRK_SSP_S_2`
* ``num_of_stages = 9`` for :c:enumerator:`ARKODE_LSRK_SSP_S_3`
* ``num_of_stages = 2`` for :c:enumerator:`ARKODE_LSRK_SSP_S_2`
* ``num_of_stages = 4`` for :c:enumerator:`ARKODE_LSRK_SSP_S_3`
* ``num_of_stages = 10`` for :c:enumerator:`ARKODE_LSRK_SSP_10_4`

This routine will be called by :c:func:`ARKodeSetOptions`
when using the key "arkid.num_ssp_stages".

.. versionchanged:: x.y.z

The default numbers of stages for :c:enumerator:`ARKODE_LSRK_SSP_S_2` and :c:enumerator:`ARKODE_LSRK_SSP_S_3`
were changed from 10 and 9, respectively, to their minimum allowable values of 2 and 4.


.. _ARKODE.Usage.LSRKStep.OptionalOutputs:

Optional output functions
Expand Down
5 changes: 5 additions & 0 deletions doc/shared/RecentChanges.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@

**New Features and Enhancements**

The default numbers of stages for the SSP Runge--Kutta methods :c:enumerator:`ARKODE_LSRK_SSP_S_2`
and :c:enumerator:`ARKODE_LSRK_SSP_S_3` in LSRKStep were changed from 10 and 9, respectively, to
their minimum allowable values of 2 and 4. Users may revert to the previous values by calling
:c:func:`LSRKStepSetNumSSPStages`.

**Bug Fixes**

**Deprecation Notices**
14 changes: 7 additions & 7 deletions examples/arkode/CXX_manyvector/ark_sod_lsrk.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@

Problem parameters and options:
---------------------------------
---------------------------------
gamma = 1.4
---------------------------------
---------------------------------
tf = 0.1
xl = 0
xr = 1
nx = 512
dx = 0.00195312
---------------------------------
---------------------------------
integrator = ARKODE_LSRK_SSP_10_4
rtol = 0.0001
atol = 1e-11
fixed h = 0
---------------------------------
---------------------------------
output = 1
---------------------------------
---------------------------------

t ||rho|| ||mx|| ||my|| ||mz|| ||et||
--------------------------------------------------------------------------
Expand All @@ -42,7 +42,7 @@ Error test fails = 96
NLS step fails = 0
Inequality constraint fails = 0
Initial step size = 1.12228425974954e-14
Last step size = 0.000245077722421064
Current step size = 0.000245077722421064
Last step size = 0.000245077738498855
Current step size = 0.000245077738498855
RHS fn evals = 3886
Number of stages used = 10
6 changes: 3 additions & 3 deletions examples/arkode/C_serial/ark_analytic_ssprk.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Analytical ODE test problem:
---------------------

Final Statistics:
Current time = 10.0099819208271
Current time = 10.0099819131755
Steps = 719
Step attempts = 721
Stability limited steps = 0
Expand All @@ -28,8 +28,8 @@ Error test fails = 2
NLS step fails = 0
Inequality constraint fails = 0
Initial step size = 1.93010111094261e-10
Last step size = 0.040487363965298
Current step size = 0.04065435916964
Last step size = 0.0404873638517102
Current step size = 0.0406543588860424
RHS fn evals = 6489
Number of stages used = 9

Expand Down
Loading
Loading