Fixes for builds with no raja or umpire #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebchin
commented
Jan 3, 2025
Member
Author
|
/style |
ebchin
force-pushed
the
bugfix/chin23/no-raja-umpire
branch
from
35a1037 to
d5747e1
Compare
white238
approved these changes
Jan 3, 2025
tupek2
approved these changes
Jan 3, 2025
Member
Author
|
/style |
chapman39
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in place of the (now closed) #1270.
Instead of
#ifdefs on the function declaration, I added amemory.hppwhich holds different hostaxom::MemorySpaces depending on if serac is built with Umpire or not. This variable is then used in template parameters.