-
Notifications
You must be signed in to change notification settings - Fork 34
add support for interior face integrals #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 65 commits
f27a541
26766aa
3a7c374
bd2947b
044162f
d3529fa
0e96c71
f1de1c0
dff154c
53e88be
2e25351
8f739f1
4bcd5e2
c006522
51b9dae
5082552
18af6c8
1945881
0bf2235
6270797
e21d752
e909e10
5d4a093
9a5156e
938f788
a25b076
2923c9e
303625a
0e94619
cf72418
1277916
c5032a5
726804d
686ea10
e615bed
ce09966
e824db3
f78da84
9f828b7
e3a87d1
9e43f72
b37b454
a636054
a20e7b9
af09e08
db99e0e
080e0d0
2bf54fb
7905f46
88055d1
a694fe1
3365ae3
3234970
e3a3fdd
e5e4fa9
ada95fb
e868e9c
76d1890
11bed34
22dc40b
3c8b96e
8a65b76
d1e255e
cae2d94
afb499a
9c44026
989bca6
f374a7a
50d63c3
9db8634
c9219f3
fb01e66
7249be1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've temporarily disabled these serac "drivers" since:
Keeping them enabled would add extra burden to this PR which I don't feel is justified in the near future.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a user that is currently using it for testing the memory mapped file library. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
cmake_dependent_optionis admittedly weird I think it is okay as is.SERAC_ENABLE_BENCHMARKSgenerally shouldn't be set explicitly unless you want to enable benchmarks yet disable Serac's. Simply setENABLE_BENCHMARKS.SERAC_ENABLE_BENCHMARKScan only be set ifENABLE_BENCHMARKSisON. IfENABLE_BENCHMARKSisON, it will automatically setSERAC_ENABLE_BENCHMARKStoON. OtherwiseSERAC_ENABLE_BENCHMARKSis forced toOFF.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-add
cmake_dependent_option(SERAC_ENABLE_BENCHMARKS "Enable benchmark executables" ON "ENABLE_BENCHMARKS" OFF)