Adds PROCESSORS property to tests based on number of ranks and threads #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd OpenMP threads This improves ctest's ability to schedule the tests. If NUM_MPI_TASKS or NUM_OMP_THREADS is not supplied, they are counted as 1.
kennyweiss
requested review from
adayton1,
adrienbernede,
chapman39,
cyrush,
davidbeckingsale,
rhornung67 and
white238
adayton1
reviewed
Dec 22, 2025
adayton1
reviewed
Dec 22, 2025
white238
approved these changes
Dec 22, 2025
Member
white238
left a comment
white238
left a comment
There was a problem hiding this comment.
Thanks @kennyweiss ! Did you notice a speed up after this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the
PROCESSORSproperty to tests in theblt_add_testmacro to give CTest more context in scheduling its tests.The number of processors is based on the number of mpi ranks -- provided through
NUM_MPI_TASKS-- and the number of OpenMP threads -- provided throughNUM_OMP_THREADS.We also throw a FATAL_ERROR if the number of threads is not an integer or is less than 1.
Update:
PROCESSORSproperty to tests appears to slow the testing down somewhat (~3% for the Axom tests).