-
Notifications
You must be signed in to change notification settings - Fork 8
Fix warnings, consistent include guards, clean up (some) includes #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #147 +/- ##
===========================================
- Coverage 90.68% 90.50% -0.19%
===========================================
Files 101 101
Lines 19227 19154 -73
===========================================
- Hits 17436 17335 -101
- Misses 1791 1819 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
srwopschall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebchin - Looks good. Have some comments about minor clarifications etc.
ebchin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @srwopschall , comments should be addressed now.
This PR
Follow-on PRs: