Skip to content

Conversation

@ebchin
Copy link
Member

@ebchin ebchin commented Jun 3, 2025

This PR

  • Clears all warnings up to clang 19
  • Removes variable length C-style arrays
  • Changes include guard naming to be consistent
  • Removes some of the extraneous header includes in some of the test and source files. Still some work to be done with this.

Follow-on PRs:

  • Further cleanup of extraneous header file includes

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 90.77491% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.50%. Comparing base (e4bb97f) to head (95f2ef1).
⚠️ Report is 129 commits behind head on develop.

Files with missing lines Patch % Lines
src/tribol/integ/Integration.cpp 56.09% 18 Missing ⚠️
src/tribol/geom/NodalNormal.cpp 0.00% 3 Missing ⚠️
src/tests/tribol_mortar_lm_patch_test.cpp 87.50% 2 Missing ⚠️
src/tribol/mesh/CouplingScheme.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #147      +/-   ##
===========================================
- Coverage    90.68%   90.50%   -0.19%     
===========================================
  Files          101      101              
  Lines        19227    19154      -73     
===========================================
- Hits         17436    17335     -101     
- Misses        1791     1819      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ebchin ebchin linked an issue Nov 10, 2025 that may be closed by this pull request
@ebchin ebchin changed the title Fix warnings, move to c++17, consistent include guards, clean up (some) includes Fix warnings, consistent include guards, clean up (some) includes Dec 22, 2025
@ebchin ebchin marked this pull request as ready for review December 22, 2025 04:59
@ebchin ebchin self-assigned this Dec 22, 2025
@ebchin ebchin requested a review from srwopschall December 22, 2025 05:00
@ebchin ebchin requested a review from chapman39 December 22, 2025 17:30
Copy link
Collaborator

@srwopschall srwopschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebchin - Looks good. Have some comments about minor clarifications etc.

Copy link
Member Author

@ebchin ebchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @srwopschall , comments should be addressed now.

@ebchin ebchin merged commit 4398dfc into develop Dec 23, 2025
9 checks passed
@ebchin ebchin deleted the flex-array branch December 23, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++ variable length arrays

4 participants