-
Notifications
You must be signed in to change notification settings - Fork 51
MFEM kernel updates #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MFEM kernel updates #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
commented
Jan 5, 2026
artv3
commented
Jan 5, 2026
artv3
commented
Jan 6, 2026
artv3
commented
Jan 6, 2026
Member
Author
|
I think this PR should now be good to go, @rhornung67 I fixed the compiler warnings as well. |
MrBurmark
reviewed
Jan 8, 2026
MrBurmark
reviewed
Jan 8, 2026
MrBurmark
reviewed
Jan 8, 2026
MrBurmark
reviewed
Jan 8, 2026
MrBurmark
reviewed
Jan 8, 2026
MrBurmark
reviewed
Jan 8, 2026
Member
|
This is generally looking pretty good, but its hard to see what's really changed among all of the refactoring. |
MrBurmark
reviewed
Jan 8, 2026
Co-authored-by: Jason Burmark <[email protected]>
MrBurmark
approved these changes
Jan 9, 2026
rhornung67
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR addresses issues: #578 along with major clean up passes...
Relevant kernels will be checked to be consistent with MFEM-4.9. FOM will be updated to be the DOF
Checklist: