Skip to content

Conversation

@anastasds
Copy link
Contributor

@anastasds anastasds commented Nov 19, 2025

What does this PR do?

Closes #4123

A set of changes were introduced by the pre-commit hook. The relevant change here is in streaming.py.

Test Plan

Manual verification.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2025
@mergify
Copy link

mergify bot commented Nov 19, 2025

This pull request has merge conflicts that must be resolved before it can be merged. @anastasds please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 19, 2025
@anastasds anastasds force-pushed the parallel-tool-calls-impl branch from 1dd3d09 to 958d0dc Compare November 19, 2025 19:37
@mergify mergify bot removed the needs-rebase label Nov 19, 2025
@anastasds anastasds changed the title Pass parallel_tool_calls directly and document intended usage in integration test Pass parallel_tool_calls correctly Nov 19, 2025
@anastasds anastasds changed the title Pass parallel_tool_calls correctly feat: Pass parallel_tool_calls correctly Nov 19, 2025
@ashwinb
Copy link
Contributor

ashwinb commented Nov 19, 2025

I think this PR is a bit too small -- as in, we could do more here?

@anastasds
Copy link
Contributor Author

anastasds commented Nov 20, 2025

@ashwinb It's a one line change, yes, but it fixes broken behavior. As a relative newcomer to the codebase, it took some time to figure out where the problem was - for example, grepping the codebase for "call_ led me down the wrong path for a while.

What do you have in mind for "more"? I originally had added an integration test for this after the max_tool_calls integration test for the responses API, only to find after pulling main that it had been removed. I would be happy to add it back in, but I don't know whether it will be a reliable test given that it has to do with tool calling, which, as far as I know, is known to be unreliable for anything less than the largest models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Implement parallel_tool_calls in Responses API

3 participants