-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add metadata field to request and response #4130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This changes adds Optional metadata field to OpenAI compatible request and response object. fixes: llamastack#3564 Signed-off-by: Abhishek Bongale <[email protected]>
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ llama-stack-client-node studio · code · diff
✅ llama-stack-client-kotlin studio · code · diff
✅ llama-stack-client-go studio · code · diff
✅ llama-stack-client-python studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
mattf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhibongale which llm did you use for this?
the linked issue (#3564) correctly states the Responses API supports a metadata param.
this patch adds a metadata param to /v1/completions, /v1/chat/completions, and /v1/embeddings, of which only chat accepts a metadata param. it fails to add metadata to the /v1/responses api.
please use a prompt like -
add a metadata param to the /v1/responses api that accepts a dict[str, str]. the responses api is defined under agents in src/llama_stack/apis/agents/agents.py and implemented by src/llama_stack/providers/inline/agents/meta_reference/agents.py
|
@mattf Thank you — I’ll make the changes. I used Gemini and ChatGPT’s research features to explain and suggest code changes. I guess I’ll use documentation rather than relying solely on LLMs. |
|
This pull request has merge conflicts that must be resolved before it can be merged. @abhibongale please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
This changes adds Optional metadata field to OpenAI compatible request and response object.
fixes: #3564