feat(openai_movement): Change URL structures to kill /openai/v1 (part 1) #3587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
raghotham
approved these changes
Sep 27, 2025
Why? We are breaking backwards compatibility with 0.3.0 -- what is the additional rationale for having both? Is there a reason I am missing? |
ashwinb
changed the title
cdoern
suggested changes
Sep 29, 2025
There was a problem hiding this comment.
the API Conformance test is passing because its no longer checking anything given that it looks for v1/openai/v1. I can look into this in a follow up if you want, but instead of doing --match-path '^/v1/openai/v1' I think we now need to check for all APIs we want to ensure don't change (all of the ones that used to be behind the openai/v1)
|
@cdoern updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/v1/openai/v1prefix is annoying and now unnecessary given our clearer focus on how to think about the API surface.Let's kill it for the 0.3.0 update.
To make client-side changes feasible, we will do this in two parts. This part adds a new route (sans
/openai/v1) so the existing client continues to work since the server supports both.The next PR will be client-side (Stainless) changes which I will be making shortly.
The final PR will remove the
/openai/v1routes.Note that all these changes will happen rapidly within this release cycle. The entire set will be backwards incompatible.