fix: ensure usage is requested if telemetry is enabled #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: llamastack#3420 When telemetry is enabled the router uncondionally expects the usage attribute to be availble and fails if it is not present. Telemetry is not currently being requested by litellm_openai_mixin.py for streaming requests which means that providers like vertexai fail if telemetry is enabled and streaming is used. This is part of the required fix. Other part is in litell, will plan to submit PR for that soon. Signed-off-by: Michael Dawson <[email protected]>
mhdawson
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
mhdawson
added a commit
to mhdawson/litellm
that referenced
this pull request
Sep 26, 2025
Refs: llamastack/llama-stack#3571 Llama stack unconditionally expects usage information when using Responses API and streaming when telemetry is enabled. For full details see llamastack/llama-stack#3571. Debugging that issue revealed that LiteLLM does not honour a request for usage when streaming and using the vertex api. This PR adds that reporting using the same function as used elsewhere. Signed-off-by: Michael Dawson <[email protected]>
4 tasks
|
LG |
|
For reference here is the PR in liteLLM - BerriAI/litellm#14961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refs: #3420
When telemetry is enabled the router uncondionally expects the usage attribute to be availble and fails if it is not present.
Usage is not currently being requested by litellm_openai_mixin.py for streaming requests when using the responses API which means that providers like vertexai fail if telemetry is enabled and streaming is used.
This is part of the required fix. Other part is in liteLLM, will plan to submit PR for that soon.
Test Plan
I applied this change along with the change for litellm in a llama stack deployment and validated that I could make streaming requests through the responses API to a gemini model and they would succeed instead of failing due to the missing usage attribute when telemetry is enabled.