Conversation
- Reuse the workspace's stored elevated bot token to create the reads channel inline on room creation — no second OAuth once a workspace has enabled team reads. Falls back to the one-time upgrade link otherwise. - Defer modal-submission room creation to after() with a loading view so the added Slack API calls can't trip the ~3s view_submission timeout. - Pin the team-reads OAuth consent to the acting workspace via the `team` param, so multi-workspace users don't authorize the wrong one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/mumbl joinfor newcomers — invite + pin in a single command for teammates with no mumbl account; pins key on Slack identity with a nullablemumbl_user_id, backfilled on connect (migration0002). App Home lists pins by Slack identity so a just-joined user sees the room without connecting.teamparam so multi-workspace users authorize the right workspace.after()with a loading view so added Slack API calls can't trip the ~3sview_submissiontimeout / report "failed but created".mumbl-prefix from private channel names; warmer team invite message.Migration
Requires
supabase/migrations/0002_nullable_pinned_space_user.sqlapplied to prod before/with deploy.Testing
Data-layer smoke test (
scripts/slack-join-smoke.mjs) passes against the linked DB. Slack API paths need a live workspace to exercise end-to-end.🤖 Generated with Claude Code