Repository navigation
fix(subsonic): play flow and playlist songs outside the Library in Music Assistant - #1874
Merged
Merged
Conversation
Performance: Nothing is slower than main.50,336 tracks, 2 alternating rounds per side, lower quartiles.
|
Preview image:
|
lklynet
force-pushed
the
fix/subsonic-playlist-song-parent
branch
from
November 13, 2026 17:09
5d6ea7f to
5dbf72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow and playlist songs that aren't in the Library got skipped in Music Assistant. They reported
parent: flow:<id>(orshared:<id>), MA looks that up withgetAlbum, andgetAlbumonly knows albums, so it answered "not found" and MA dropped the track. Fixes #1745.Songs now only point at an album that exists:
parent, the same asgetSongreturns for that id.parentandalbumId. The Subsonic spec makesparentoptional, and MA plays a track with no album id.album:unknownparent.Proof: two new assertions in the Subsonic integration tests fail on
mainand pass here;pnpm run check,pnpm test, andpnpm run test:integrationpass.Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.