Repository navigation
feat(playlists): drag to reorder sidebar playlists and sort the Playlists page - #1864
Merged
Merged
Conversation
Preview image:
|
Performance: Nothing is slower than main.50,336 tracks, 2 alternating rounds per side, lower quartiles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playlists only showed up in the order you created them, in both the sidebar and Library > Playlists. A user asked for recently played order and sort options. Reordering the sidebar by play history would shuffle it while you listen, so the sidebar gets a stable order you set yourself, and the page gets a sort.
updatedAt. It changes only when the name, description, or track list changes, so MBID enrichment, setting toggles, and re-syncs that change nothing don't count. Existing playlists start at their created date. Subsonic playlistchangednow uses it too. Before, it never moved when tracks changed.Two behavior notes:
playlistsresponse bytes rose from 4503 to 4737, for the newupdatedAtfield on each playlist. Nothing else moved.At rest, the sidebar looks the same as before.
Proof:
pnpm run checkandpnpm testpass. New tests cover whenupdatedAtchanges and when it doesn't, the order endpoint keeping only playlists the user can see, the order merge, and Subsonicchangedafter a rename (fails on main). In a browser against Eden: pointer drag, keyboard reorder, no navigation after a drag, click and Enter still navigate, reset, page sort, phone width.Reviewed with sol-loop: 2 rounds with gpt-6.1-sol on high. Sol verdict: approved
Created with Opus 5.5 in Claude Code (T3 Code).