Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I know this is a (very) early PR, but I wanted to start off the conversation. I'm looking to test firewall rulesets and the like and LKL seems to be a really good way to do that - except it doesn't have firewall support.
The change I've made compiles in all of the netfilter / iptables modules. This is sufficient to allow
iptables
to show and list any rules. I wrote a hacky bit of code to inject a rule as part of thehijack
lib, and was able to see it withiptables -L
. A simple set of tests withping
also confirmed that the rules were working as expected.liblkl.so
is about 6MB larger after this change.Of course, this set up is not going to be very useful without being able to load a proper rule set. My current plan is to compile
iptables
as a library and modifyhijack
to load the provided ruleset as part of initialisation.I'm keen to contribute back to the project and I'm completely happy to change or implement this differently if that would be preferred.
As before, any guidance would be gratefully received :)
This change is