lkl: add LKL_HIJACK_NET_QDISC to configure qdisc policy #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavip
reviewed
Feb 9, 2017
liuyuan10
reviewed
Feb 9, 2017
Documentation/lkl.txt
Outdated
| @@ -202,6 +202,12 @@ are the list of those variable for your environment. | |||
| $ LKL_HIJACK_NET_NEIGHBOR="192.168.13.100|12:34:56:78:9a:bc;2001:db8:0:f101::3|12:34:56:78:9a:be" | |||
| lkl-hijack.sh ip neighbor show | |||
| ``` | |||
| * LKL_HIJACK_NET_QDISC | |||
|
|
|||
| Add a qdisc entry in the form of "ip|mac;ip|mac;...". | |||
tools/lkl/include/lkl.h
Outdated
| * @entries - strings of qdisc configurations in the form of | ||
| * "root|type;root|type;..." | ||
| */ | ||
| void lkl_qdisc_parse_add(int ifindex, char* entries); |
There was a problem hiding this comment.
I don't think this should be part of lkl.h.
There was a problem hiding this comment.
the same reason as #319 (comment)
I believe those are useful for others.
maybe other LKL_HIJACK_xxx configs (arp, nd, etc) can be moved in this sense.
Ah thanks, I found those issues. will fix them. I was wondering why circleci didn't report those though.. |
good catch - I will add a test. |
thehajime
force-pushed
the
feature-qdisc
branch
4 times, most recently
from
ed5837f to
024dc9d
Compare
tavip
approved these changes
Feb 9, 2017
Also enable SCH_FQ to be able to use it. Signed-off-by: Hajime Tazaki <[email protected]>
thehajime
force-pushed
the
feature-qdisc
branch
from
024dc9d to
b376786
Compare
liuyuan10
approved these changes
Feb 9, 2017
Off topic: I found I configured SKIP_CHECKPATCH in my circleci instance and this prevents me to check the style in advance. So everything is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable SCH_FQ to be able to use it.
Signed-off-by: Hajime Tazaki [email protected]
This change is