Skip to content

ai/live: Add a desync query parameter to WHEP. #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
j0sh wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ai/live: Add a desync query parameter to WHEP. #3783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion media/whep_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ func (s *WHEPServer) CreateWHEP(ctx context.Context, w http.ResponseWriter, r *h
return
}

// Read any query params
queryParams := r.URL.Query()
desync := queryParams.Get("desync") != ""

// Read the SDP offer
offerBytes, err := io.ReadAll(r.Body)
if err != nil {
Expand Down Expand Up @@ -108,11 +112,18 @@ func (s *WHEPServer) CreateWHEP(ctx context.Context, w http.ResponseWriter, r *h
hasVideo = true

case *mpegts.CodecOpus:
// if tracks share the same mid the browser will sync them for playback
// this may lead to buffering / latency so use a separate mid if requested
audioMid := "livepeer"
if desync {
clog.Info(ctx, "Using a separate mid for audio")
audioMid = audioMid + "-audio"
}
webrtcTrack, err := NewLocalTrack(
// NB: Don't signal sample rate or channel count here. Leave empty to use defaults.
// Opus RTP RFC 7587 requires opus/48000/2 regardless of the actual content
webrtc.RTPCodecCapability{MimeType: webrtc.MimeTypeOpus},
"audio", "livepeer", // NB: can be another MediaID to desync a/v for latency
"audio", audioMid, // NB: can be another MediaID to desync a/v for latency
)
if err != nil {
clog.InfofErr(ctx, "Error creating track for opus", err)
Expand Down
Loading