Skip to content

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Aug 14, 2025

This allows us to stream segments from one in-memory location to another. New reads will always start at the beginning of the current segment.

Also make the original MediaWriter follow io.WriteCloser

Needed for #3689

This allows us to stream segments from one in-memory location to another.
New reads will always start at the beginning of the current segment.

Also make the original MediaWriter follow io.WriteCloser
@github-actions github-actions bot added go Pull requests that update Go code labels Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.70296%. Comparing base (4044283) to head (cc18b19).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
media/segment_rw.go 96.15385% 2 Missing and 1 partial ⚠️
media/rw.go 66.66667% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3705         +/-   ##
===================================================
+ Coverage   31.59467%   31.70296%   +0.10829%     
===================================================
  Files            157         158          +1     
  Lines          47527       47617         +90     
===================================================
+ Hits           15016       15096         +80     
- Misses         31617       31626          +9     
- Partials         894         895          +1     
Files with missing lines Coverage Δ
media/rw.go 90.14085% <66.66667%> (+0.14085%) ⬆️
media/segment_rw.go 96.15385% <96.15385%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609f722...cc18b19. Read the comment docs.

Files with missing lines Coverage Δ
media/rw.go 90.14085% <66.66667%> (+0.14085%) ⬆️
media/segment_rw.go 96.15385% <96.15385%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh enabled auto-merge (squash) August 19, 2025 00:50
@j0sh j0sh merged commit 99e4fde into master Aug 19, 2025
15 of 16 checks passed
@j0sh j0sh deleted the ja/segmented-ringbuffer branch August 19, 2025 01:02
closed bool
}

type writerWrapper struct{ mw *MediaWriter }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but just curious do we need this struct? It doesn't have any extra functions on top of io.WriteCloser I think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, wanted to add a Seq() similar to the reader side but didn't get that in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants