refactor(byoc): use pytrickle warmup routine, improve prompt execution #484
+126
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a runner state management in ComfyStreamFrameProcessor to control prompt execution. - Updated methods in ComfyStreamClient to support pausing and resuming prompt tasks. - Improved warmup logic to ensure prompt tasks are running before processing frames. - Refactored cleanup and cancellation logic for better task management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures health state transitions from
LOADINGtoIDLEfollowing pipeline initialization. This change is dependent on livepeer/pytrickle#36This PR also modifies the warmup routine so that prompts are stopped after warmup.
The pipeline input methods
put_video_frameandput_audio_framenow ensure prompts are running when input frames arrive. This avoids the race condition of stopping running prompts after warmup occurs for an active stream while also preventing "running zombie prompts" following warmup