Added test with cancel #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishadmusthafa
approved these changes
Nov 6, 2025
alexlivekit
commented
Nov 6, 2025
Comment on lines
+647
to
+657
| func (c *inboundCall) appendLogValues(kvs ...any) { | ||
| c.setLog(c.log().WithValues(kvs...)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Does this solve the race?
You can still have two threads getting the same logger via c.log()..., creating a derivative via .WithValues(kvs...), and racing to store their version via c.setLog(). What am I missing?
Having said that, it should be just fine landing this since this is an improvement and carries no degradation.
alexlivekit
force-pushed
the
cancel-test
branch
from
3f94076 to
776223f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.