Repository navigation
TEMPORARY: require explicit msg_type for inbound topics (BOT-301) - #35
Closed
stephen-derosa wants to merge 1 commit into
Closed
stephen-derosa wants to merge 1 commit into
stephen-derosa wants to merge 1 commit into
Conversation
Isolated single commit re-adding the temporary inbound msg_type stopgap on top of the clean integration branch, for continued integration testing. LiveKit DataTracks do not yet carry ROS message-type metadata, so a pure consumer cannot infer an inbound track's type; this lets the bridge create the republishing publisher from a configured type. Drop this commit (it is the exact inverse of "Drop temporary inbound msg_type stopgap (BOT-301)" on sderosa/integration-clean) once DataTracks propagate the ROS type with the track. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BOT-301 Services <> RPC
NOTE: RPC calls currently only take in strings. So this is blocked by MCAP header in DataTracks work. cc jacobgelman to reference ticket number. NOTE: while this can be targeted for V1.25/1.5 this work is imperitive to a complete project. If the rest of the project is complete and this is all thats left we can simply use strings and encode the ros2 messages as base64. |
Collaborator
Author
|
closed in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated single commit re-adding the temporary inbound msg_type stopgap on top of the clean integration branch, for continued integration testing. LiveKit DataTracks do not yet carry ROS message-type metadata, so a pure consumer cannot infer an inbound track's type; this lets the bridge create the republishing publisher from a configured type.
Drop this commit (it is the exact inverse of "Drop temporary inbound msg_type stopgap (BOT-301)" on sderosa/integration-clean) once DataTracks propagate the ROS type with the track.