ChatManager to manage sending/receiving of chat messages

[davidzhao]

No description provided.

[davidzhao]

@theomonnom I can't seem to load the shared libs in the test here. Any ideas?

[theomonnom]

We need to download the FFI binaries inside the test workflow. Will do it tmrw

It is as easy as executing the download-ffi.py script to the resources path

[davidzhao]

We need to download the FFI binaries inside the test workflow. Will do it tmrw

It is as easy as executing the download-ffi.py script to the resources path

that worked. Thanks!

[keepingitneil]

Should this class also accumulate chat messages with a sane default way of updating chat messages (i.e. setting deleted from false to true)?

[davidzhao]

yeah I def want to in the future.. just wanted to keep it simple because if we started buffering, we'd need a way to clean it up too to avoid it buffering forever

[keepingitneil]

@davidzhao @theomonnom I did it here as well. Maybe this can be a shared workflow step: https://github.com/livekit/python-sdks/pull/135/files#diff-4fdc48ab490b670c90974725b8e3d399b24c03d6d09563acf8ea87d4113930fbR55

[theomonnom]

@davidzhao @theomonnom I did it here as well. Maybe this can be a shared workflow step: https://github.com/livekit/python-sdks/pull/135/files#diff-4fdc48ab490b670c90974725b8e3d399b24c03d6d09563acf8ea87d4113930fbR55

No need, it's one internal line. I think you're complicating it inside your build_docs workflow. Only livekit-rtc needs it

[theomonnom]

We don't have CI yet, but here are some types complaints with mypy

[davidzhao]

@theomonnom I don't have mypy setup.. It'll be faster if you can please fix lint issues directly. I'd like to get this released so we can update everything else

[theomonnom]

done, lgtm!

[theomonnom]

nvm last thing is: do we need on_message_updated?
Ok to merge before anyway

[davidzhao]

nvm last thing is: do we need on_message_updated? Ok to merge before anyway

Thanks! we don't need it right now. Will add this once finalized across clients