Skip to content

Conversation

davidliu
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 16, 2025

🦋 Changeset detected

Latest commit: f22be17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from cloudwebrtc September 16, 2025 08:43
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

}
val payload = LivekitModels.EncryptedPacketPayload.parseFrom(decryptedData)

dp = with(dp.toBuilder()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for encrypted payloads it would be great to add some encryption metadata (i.e. encryptionType) to forward to the callbacks.

The reason being that we can then surface whether or not a packet was actually encrypted (if that's possible in a non breaking way) and error out on data streams that have inconsistent encryption during their lifetime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants