Properly dispose peer connection on RTC thread (#506)

* Properly dispose peer connection on RTC thread * changeset
livekit · Sep 16, 2024 · 619cd4c · 619cd4c
1 parent bcb54c6
commit 619cd4c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/angry-snails-breathe.md b/.changeset/angry-snails-breathe.md
@@ -0,0 +1,5 @@
+---
+"client-sdk-android": patch
+---
+
+Properly dispose peer connection on RTC thread
diff --git a/livekit-android-sdk/src/main/java/io/livekit/android/dagger/RTCModule.kt b/livekit-android-sdk/src/main/java/io/livekit/android/dagger/RTCModule.kt
@@ -35,6 +35,7 @@ import io.livekit.android.webrtc.CustomAudioProcessingFactory
 import io.livekit.android.webrtc.CustomVideoDecoderFactory
 import io.livekit.android.webrtc.CustomVideoEncoderFactory
 import io.livekit.android.webrtc.peerconnection.executeBlockingOnRTCThread
+import io.livekit.android.webrtc.peerconnection.executeOnRTCThread
 import livekit.org.webrtc.AudioProcessingFactory
 import livekit.org.webrtc.EglBase
 import livekit.org.webrtc.Logging
@@ -317,7 +318,13 @@ internal object RTCModule {
                     }
                 }
                 .createPeerConnectionFactory()
-                .apply { memoryManager.registerClosable { dispose() } }
+                .apply {
+                    memoryManager.registerClosable {
+                        executeOnRTCThread {
+                            dispose()
+                        }
+                    }
+                }
         }
     }