Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved TTFB metrics for streaming TTS #1431

Merged
merged 4 commits into from
Jan 30, 2025
Merged

improved TTFB metrics for streaming TTS #1431

merged 4 commits into from
Jan 30, 2025

Conversation

davidzhao
Copy link
Member

for streaming TTS that were sentence based, it was counting the time to generate the first sentence in the TTFB metrics.

for TTS that were sentence based, it was counting the time to generate
the first sentence in the TTFB metrics.
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 6ef9513

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
livekit-plugins-elevenlabs Patch
livekit-plugins-cartesia Patch
livekit-plugins-deepgram Patch
livekit-plugins-playai Patch
livekit-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, ideally I wanted subclass to not worry about metrics at all but I don't see another solution.
Agree that it doesn't make sense for the LLM generation to be included inside this delay.

@davidzhao davidzhao merged commit f88d72e into main Jan 30, 2025
13 of 14 checks passed
@davidzhao davidzhao deleted the fix-tts-ttfb branch January 30, 2025 17:39
This was referenced Jan 30, 2025
gianpaj added a commit to gianpaj/call-me-please that referenced this pull request Feb 2, 2025
- [email protected]
PlayAI: Avoid websocket reconnections for each request - livekit/agents#1387

- [email protected]
improved TTFB metrics for streaming TTS - livekit/agents#1431
PlayAI plugin: bump Python SDK version (fix websockets interrupt handling) - livekit/agents#1427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants