fix(pipeline_agent): clear user transcript when before_llm_cb returns false #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e4de3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
s-hamdananwar
changed the title
s-hamdananwar
changed the title
davidzhao
reviewed
Jan 29, 2025
Co-authored-by: David Zhao <[email protected]>
davidzhao
approved these changes
Jan 30, 2025
|
@s-hamdananwar can you run |
|
@davidzhao no idea why ruff check is failing on GH actions, running it locally on |
This was referenced Jan 30, 2025
Merged
egoldschmidt
added a commit
to portolans/livekit-agents
that referenced
this pull request
Feb 3, 2025
… returns false (livekit#1423)" This reverts commit c83a703.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1422