Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ClientOptions in google stt client #1098

Conversation

brightsparc
Copy link
Contributor

@brightsparc brightsparc commented Nov 17, 2024

cc @theomonnom

Copy link

changeset-bot bot commented Nov 17, 2024

🦋 Changeset detected

Latest commit: 32f25af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-google Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brightsparc
Copy link
Contributor Author

@theomonnom could you please also review, approve this update which improves the last change.

@davidzhao
Copy link
Member

sorry for the delays here. we'll get this one in soon

Copy link
Collaborator

@jayeshp19 jayeshp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayeshp19 jayeshp19 merged commit e5cfd32 into livekit:main Jan 31, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
@jayeshp19 jayeshp19 changed the title enh: Update to also pass ClientOptions to credentials args add ClientOptions in google stt client Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants