Added support for custom deepgram base url #1088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0fe5f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
theomonnom
reviewed
Nov 14, 2024
livekit-plugins/livekit-plugins-deepgram/livekit/plugins/deepgram/stt.py
Outdated
Show resolved
Hide resolved
theomonnom
approved these changes
Nov 15, 2024
|
It seems like I don't have write access to this PR, can you click on the changesets comment to add one 🙏 |
theomonnom
reviewed
Nov 15, 2024
livekit-plugins/livekit-plugins-deepgram/livekit/plugins/deepgram/stt.py
Outdated
Show resolved
Hide resolved
livekit-plugins/livekit-plugins-deepgram/livekit/plugins/deepgram/stt.py
Outdated
Show resolved
Hide resolved
|
Hey you removed the wrong lines 😅 |
|
Okay everything should hopefully be resolved now |
|
@theomonnom @davidzhao are you able to re-review please |
|
@theomonnom @davidzhao can this be merged please? |
|
@theomonnom @davidzhao any update here please? |
Will take a look at it this evening |
|
replaced by #1137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.