-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SBSE 4.0 battery (dis)charge power #7
Conversation
The profile name with `.1` included does not appear in the ennexosSensors list and is therefore never picked up.
Btw, I'd be perfectly fine with German as well if that's easier for you, I just stick to English to avoid needlessly excluding folks. |
<german, damit es schneller geht> Unterscheiden sich bei dir BatDsch.CurBatDsch und BatChrg.CurBatChaArr.1? Aber trotzdem es für die Zukunft korrigieren.
Both refer to the total amount, so that each should be assigned to the "total" sensor.
These two refer to the first battery, so "_a" should be used. Agree to the following?
|
* `CurBatChaArr.1` is a subcomponent of the overall value in `CurBatCha`, thus it should have the `_a` identifier. * Swap the `_a` and `_total_` identifiers for `CurBatDsch` and `CurBatDschArr.1`, reflecting the subcomponent hierarchy as well. In both cases, the `Arr.1` value is slightly different from the total value for me, but it is not obvious why and how. I just have one battery, so in my world they should be the same. Therefore I'd stick to the hierarchical setup. If needed both can be made available in Home Assistant.
2f26e55
to
fa31597
Compare
Intuitiv hätte ich gesagt "natürlich sind die gleich" - aber nein. Ich hatte hier grade schwankend ein bisschen Ladung und ein bisschen Entladung (zweistelliger Bereich). Beim Laden ist der Wert von
Same here, same here... I updated the code with your proposal. Of course the |
There was a mismatch between the profile name in the device profile and the sensor name given in
ennexosSensors
:BatDsch.CurBatDsch.1
vsBatDsch.CurBatDsch
. I think applying both commits in this PR moves it in the right direction since it matches the pattern I see forBatChrg.CurBatCha
.However, I'm not entirely sure this is correct. See these sensor definitions (including this PR):
Each pair of sensors now shares the same identifier. That was already the case for
CurBatCha
and is now also the case forCurBatDsch
- and leads to the uglierArr.1
values overriding the overall charge/discharge power sensors if I'm not mistaken.This feels like we might need a number of additional identifiers for elements of the battery array - or drop reporting them... 🤔
Just for the record, I tested with an SBSE 4.0 running firmware 03.08.11.R.