chore: 0.35.1rc6 — doc audit gaps, healthcheck fix, update/uninstall guides#304
Merged
Nathan Schram (nathanschram) merged 4 commits intodevfrom Apr 15, 2026
Merged
Conversation
Comprehensive audit of all 121 doc files against the v0.35.1 changelog (23 issues) found the major features well-documented but 8 specific gaps: Security: - group-chat.md: document callback sender validation in groups (#192) - security.md: cross-reference button validation from allowed_user_ids - security.md: fix misleading SSRF allowlist claim (no TOML setting exists) - security.md: add bot token auto-redaction tip (#190) UX: - plan-mode.md: document auto-approval after plan approval (#283) - interactive-approval.md: note about plan bypass in diff preview section - commands-and-directives.md: /ping description now mentions trigger summary Completeness: - runners/amp/runner.md: add sanitize_prompt() note (#194) - troubleshooting.md: document 10 MB engine output line cap (#191) - glossary.md: add delayed run, webhook action, hot-reload entries Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Two bugs in scripts/healthcheck.sh made post-deploy health checks unusable: 1. pass()/fail() used `((var++))` which returns the pre-increment value. On first call (var=0) that trips `set -e`, so only the first check ever ran and the script always exited 1. Switched to explicit assignment. 2. The error-log count piped journalctl through `grep -c .`, which counts journalctl's `-- No entries --` meta line as a match, producing a false-positive "1 ERROR-level log entries in last 60s" on clean systems. Now filters meta lines with `grep -vc '^-- '`. Verified with `scripts/healthcheck.sh --version 0.35.1rc5` on staging: all 5 checks run, exit 0. Closes #302 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
- New how-to guides: docs/how-to/update.md and docs/how-to/uninstall.md - README: "What Untether accesses" section with network, filesystem, process, and credential disclosures - README: update/uninstall one-liner in Quick Start section - README: update/uninstall links in How-To Guides section - install.md: cross-links to update and uninstall guides - zensical.toml: nav entries for new pages - how-to/index.md: entries in Getting Started section Addresses gap found during hesreallyhim/awesome-claude-code evaluation: the repo had zero uninstallation documentation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…install guides Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Staging rc6 bundles three independent bodies of work:
((var++))under set -e #302)1. Documentation audit (8 files, 38 insertions)
Audited all 121 doc files against the 23 issues in v0.35.1. Major features (triggers,
/at, hot-reload, restart improvements, OOM fix, stall improvements) were already well-documented. Filled 8 specific gaps:Security:
group-chat.md— new "Button press validation" section (security: callback query sender not validated in group chats #192)security.md— cross-reference to group validation, fixed misleading SSRF allowlist claim, added bot token auto-redaction tip (security: bot token leaked in structured log URLs #190)UX:
plan-mode.md— new "Auto-approval after plan approval" section (bug: diff_preview gate requires manual approval for every tool after ExitPlanMode in plan mode #283)interactive-approval.md— admonition linking to plan bypass behaviourcommands-and-directives.md—/pingnow mentions uptime reset and trigger summary (bug: /ping uptime does not reset on service restart #234)Completeness:
runners/amp/runner.md—sanitize_prompt()note matching Pi/Gemini runner docs (security: user prompt passed as CLI arg without -- separator (flag injection) #194)troubleshooting.md— new "Engine output line cap" section for the 10 MB limit (security: unbounded JSONL line buffer can cause OOM crash #191)glossary.md— three new entries: delayed run, webhook action, hot-reload2. healthcheck.sh fix (#302)
Two bugs in
scripts/healthcheck.shmade post-deploy health checks unusable:pass()/fail()used((var++))which returns pre-increment value, trippingset -eon first callgrep -c .counted journalctl's-- No entries --meta lineVerified with
scripts/healthcheck.sh --version 0.35.1rc5on staging — all 5 checks run, exit 0.3. Update/uninstall guides
docs/how-to/update.mdanddocs/how-to/uninstall.mdAddresses a gap found during
hesreallyhim/awesome-claude-codeevaluation: the repo had zero uninstallation documentation.Test plan
uv run ruff format --check src/ tests/— passes (260 files formatted)uv run ruff check src/— passes (all checks passed)uv lock --check— lockfile in syncuv run pytest— 2164 passed, 1 skipped, 81.65% coverageuv build— wheel and sdist built successfullyuv run zensical build— docs build clean, no broken linksrelease.yml)@hetz_lba1_botviascripts/staging.sh install 0.35.1rc6after dev merge@untether_dev_botbefore final v0.35.1 release🤖 Generated with Claude Code