Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if running state skipped #4952

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ParkChangSun
Copy link
Contributor

@ParkChangSun ParkChangSun commented Nov 20, 2024

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

This PR fixes chaos experiment node status decision logic in subscriber to solve issue 4837

Screencast_20241121_055228.webm

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

@ParkChangSun ParkChangSun marked this pull request as draft November 20, 2024 21:27
@ParkChangSun
Copy link
Contributor Author

CI says the code I fixed have CVE-2024-3596 vulnerability, did I do something wrong?

@namkyu1999
Copy link
Member

CI says the code I fixed have CVE-2024-3596 vulnerability, did I do something wrong?

This security issue is irrelevant to your PR, please make this pr active when you are ready for review.

Copy link
Member

@neelanjan00 neelanjan00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants