Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Litestar SQLAdmin with SQLAdminPlugin. #3

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

rafalkrupinski
Copy link
Contributor

Following sqladmin-litestar readme, replace the link with sqladmin-litestar-plugin.

@rafalkrupinski rafalkrupinski requested review from a team as code owners July 10, 2024 14:03
@rafalkrupinski
Copy link
Contributor Author

BTW, there is a whole bunch of changes coming from pre-commit hook. Am I the first to actually run it? :D

@rafalkrupinski
Copy link
Contributor Author

rafalkrupinski commented Jul 10, 2024

BTW2 There's a whole bunch of python-specific hooks that require download and slow down the first commit.
Also, is it necessary to check links both in pre-commit and GHA?

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, wanted to check with the other author to ensure they wanted to just show this one or keep both

@JacobCoffee JacobCoffee merged commit 5710395 into litestar-org:main Jul 15, 2024
0 of 2 checks passed
@JacobCoffee
Copy link
Member

@rafalkrupinski i dont think so, but ill check out this repo and see what its doing when i get get settled w/ new job. probably just needs some tlc and feeding :D

@rafalkrupinski rafalkrupinski deleted the feat/replace-sqladmin branch July 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants