-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct build url based on if its a dev of pr image. #58
Set correct build url based on if its a dev of pr image. #58
Conversation
Add test for build_url function.
I am a bot, here is the pushed image/manifest for this PR:
|
The link is correct but the text isn't going to match. Perhaps instead of:
Just do something like:
And then similarly just the image tag in the per-arch summaries? We know if it's live/dev/pr based on the tag format anyway and can just prepend |
Perhaps we can change the text to match the ghcr image and tag The text and link used to be for docker hub images. We changed the link to ghcr, but the text is still docker hub. Perhaps we match them again? |
As we've pretty much moved to GHCR as the primary option across the board then yeah, we might as well change the text to match |
👍🏻 |
Add More information to build info section in the report. Center and split the top report headers
New test with some report changes.
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
lsiodev test:
https://gilbnlsio2.s3.us-east-1.amazonaws.com/lsiodev/lidarr/2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71/index.htmllspipepr test:
https://gilbnlsio2.s3.us-east-1.amazonaws.com/lspipepr/lidarr/2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71-pr-107/index.htmllinuxserver test:
https://gilbnlsio2.s3.us-east-1.amazonaws.com/linuxserver/lidarr/2.5.3.4341-ls10/index.htmlhttps://gilbnlsio2.s3.us-east-1.amazonaws.com/lspipepr/lidarr/2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71-pr-107/index.html