Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct build url based on if its a dev of pr image. #58

Merged

Conversation

@GilbN GilbN linked an issue Sep 18, 2024 that may be closed by this pull request
1 task
@GilbN GilbN assigned GilbN, aptalca and thespad and unassigned GilbN Sep 18, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:2e036dc5-pkg-2e036dc5-dev-e1575730d9916983033f8849fdf05487cf4eb05e-pr-58

@thespad
Copy link
Member

thespad commented Sep 18, 2024

The link is correct but the text isn't going to match. Perhaps instead of:

Test Results lsiodev/lidarr:2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71

Just do something like:

Test Results lidarr:2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71

And then similarly just the image tag in the per-arch summaries?

We know if it's live/dev/pr based on the tag format anyway and can just prepend lsiodev/ or ghcr.io/linuxserver/ etc. if we need to pull them.

@aptalca
Copy link
Member

aptalca commented Sep 19, 2024

Perhaps we can change the text to match the ghcr image and tag

The text and link used to be for docker hub images. We changed the link to ghcr, but the text is still docker hub. Perhaps we match them again?

@thespad
Copy link
Member

thespad commented Sep 19, 2024

As we've pretty much moved to GHCR as the primary option across the board then yeah, we might as well change the text to match

@GilbN
Copy link
Member Author

GilbN commented Sep 19, 2024

👍🏻

Add More information to build info section in the report. Center and split the top report headers
@GilbN
Copy link
Member Author

GilbN commented Sep 22, 2024

New test with some report changes.

https://gilbnlsio2.s3.us-east-1.amazonaws.com/lspipepr/lidarr/2.3.3.4204-pkg-891c8a1a-dev-39ebb48d3454c6b0326510ac1176c93625dd9d71-pr-107/index.html

dfcf34a

  • Fixes link name.
  • Add more information to build info section in the report. Center and split the top report headers

@thespad @aptalca

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:25eb60ca-pkg-25eb60ca-dev-7eac1c2cc537fb2442eaf488d73414a1c353ca53-pr-58

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:25eb60ca-pkg-25eb60ca-dev-5b80a2fef31b3acd83d5eef20c824d93132f9286-pr-58

@GilbN GilbN merged commit 0885613 into master Sep 24, 2024
5 checks passed
@GilbN GilbN deleted the 57-bug-incorrect-ghcr-link-for-lsiodev-and-lspipepr-images branch September 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] incorrect ghcr link for lsiodev and lspipepr images
4 participants