Port 3 APIs from python to golang#4736
Merged
Merged
Conversation
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
… comparing to '/v2/project/<uuid>' Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
…'true' on 2 missing fields + test coverage Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Added test coverage that compares '/vN/projects<uuid>' for N=2 and N=4
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
… old v2 one Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…e-signature-api-to-go Port /v2/user/<user-uuid>/active-signature to golang
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…erage Update test coverage
…ave as V2 APIs - accept non-v4 UUIDs Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…-wrong-uuid-case Add test coverage for non-v4 and invalid UUIDs and fix v4 APIs to behave as V2 APIs - accept non-v4 UUIDs
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…o-golang Port '/v2/user/<uuid>' py API to '/v3/user-compat/<uuid>' go API
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…aming Use inclusive naming 'whitelist' -> 'allowlist'
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
… email, name Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
…atterns-in-skip-cla Add support for patterns matching empty or missing properties: login, email, name
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports 3 APIs from Python to Golang to replace deprecated Python v2 endpoints while maintaining backward compatibility. The implementation focuses on API parity between Python and Go implementations and includes comprehensive testing infrastructure.
- Ports
/v2/project/{projectID}to/v4/project-compat/{projectID}for project details - Ports
/v2/user/{userID}/active-signatureto/v4/user/{userID}/active-signaturefor active signature metadata - Ports
/v2/user/{userID}to/v3/user-compat/{userID}for user information
Reviewed Changes
Copilot reviewed 61 out of 67 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cla-backend-go/swagger/ |
API specification updates for new endpoints and models |
cla-backend-go/v2/project/handlers.go |
Implements project compatibility API handler |
cla-backend-go/v2/sign/service.go |
Implements user active signature API service |
cla-backend-go/users/ |
Implements user compatibility API and model conversion |
tests/py2go/ |
Comprehensive test framework comparing Python vs Go API responses |
utils/ |
Utility scripts for testing and managing CLA configurations |
BOT_ALLOWLIST.md |
Documentation for bot allowlisting feature |
Comments suppressed due to low confidence (3)
tests/py2go/go.mod:3
- Go version 1.24.4 does not exist. The latest stable Go version is 1.23.x. This should be updated to a valid Go version like 'go 1.23.4' or 'go 1.22.x'.
go 1.24.4
cla-backend-go/v2/sign/service.go:1850
- Commented out debug code should be removed before production. The commented lines with 'LG:' appear to be development/testing artifacts that should be cleaned up.
contentType := document.DocumentContentType
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>
mlehotskylf
approved these changes
Aug 2, 2025
lukaszgryglicki
added a commit
that referenced
this pull request
May 7, 2026
Port 3 APIs from python to golang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mlehotskylf - release to sync
devwithmain- it only contains new APis ported frompythontogolang, this is not changing any functionality.