fix: simplify file path validation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor isLegalFile() to use QFileInfo/QDir for simpler path validation: - Ensure parent directory exists - Verify path is not a directory - Remove complex regex parsing Log: Improved file path validation reliability Bug: https://pms.uniontech.com/bug-view-303265.html
Ensure serialization consistency, after Qt6, size() uses qsizetype, default 8 bytes. Log: Fix read ddf file failed.
pengfeixx
approved these changes
Feb 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx, rb-union The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
myk1343
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor isLegalFile() to use QFileInfo/QDir for simpler path validation:
Log: Improved file path validation reliability
Bug: https://pms.uniontech.com/bug-view-303265.html
fix: Read ddf file data failed
Ensure serialization consistency, after Qt6,
size() uses qsizetype, default 8 bytes.
Log: Fix read ddf file failed.