Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cooperation-networkDisPlay service is not available #221

Merged

Conversation

yixinshark
Copy link
Contributor

as title

Log: as title
Bug: BUG-294901

as title

Log: as title
Bug: BUG-294901
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • checkServiceAvailable函数中,QDBusPendingCallWatcherdeleteLater调用应该在watcher对象的所有权被转移给QMetaObject::invokeMethod之前,以避免潜在的内存泄漏。
  • checkServiceAvailable函数中的QDBusPendingCallWatcher对象应该使用QScopedPointerQScopedPointer<QDBusPendingCallWatcher>来管理其生命周期,以确保在异步操作完成后正确删除。
  • checkServiceAvailable函数中的QDBusPendingCallWatcherfinished信号处理函数应该检查watcher对象是否已经被删除,以避免在watcher对象被删除后尝试访问它。
  • checkServiceAvailable函数中的QDBusPendingCallWatcherfinished信号处理函数应该使用QMetaObject::invokeMethod来确保在主线程中更新m_serviceAvailable状态,以避免潜在的线程安全问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 16, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 277f7b9 into linuxdeepin:master Dec 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants