Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dde-desktop unable to start #114

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

tsic404
Copy link
Contributor

@tsic404 tsic404 commented Dec 16, 2024

Forgot to install the actual service file

log: as title

Forgot to install the actual service file

log: as title
@deepin-ci-robot
Copy link

deepin pr auto review

在提供的代码更改中,主要是在 CMakeLists.txt 文件中添加了一个新的服务到 DDE_SESSION_INITIALIZED_WANTS 列表中。这个更改看起来是合理的,因为 [email protected] 是一个服务,应该被添加到 dde-session-initialized.target.wants 目录中。

不过,为了确保代码质量和一致性,我建议进行以下检查和改进:

  1. 检查服务名称的正确性:确保 [email protected] 是一个有效的服务名称,并且确实存在于系统中。

  2. 添加注释:在添加新服务时,最好添加注释说明为什么需要添加这个服务,以及它所提供的功能。这有助于其他开发者理解代码的意图。

  3. 一致性检查:确保所有服务名称的格式和命名规则保持一致,以避免未来的维护问题。

  4. 测试:在合并此更改之前,建议进行测试以确保新添加的服务能够正确地被 systemd 管理。

  5. 版本控制:如果这是一个较大的更改,考虑将其拆分为多个提交,每个提交只包含一个更改,以便更容易地跟踪和审查。

综上所述,代码更改本身是合理的,但为了提高代码质量和可维护性,建议进行上述的检查和改进。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404 tsic404 merged commit 9c65946 into linuxdeepin:master Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants