Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Password configuration should not be saved without a password #296

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 31, 2024

Password configuration should not be saved without a password

pms: BUG-298371

Password configuration should not be saved without a password

pms: BUG-298371
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • wsSetting->setInitialized(true); 更改为 wsSetting->setInitialized(keyMgmt != WirelessSecuritySetting::KeyMgmt::WpaNone); 可能会影响初始化逻辑,需要确认这一改动是否符合预期。
  • 在创建新的UUID时,使用了 while (findConnectionByUuid(uuid)) 循环,可能会导致性能问题,建议优化UUID生成逻辑。

是否建议立即修改:

  • 是,需要确认初始化逻辑的改动是否符合业务需求,并优化UUID生成逻辑以避免潜在的性能问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 2d3ac8f into linuxdeepin:master Dec 31, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants