fs/dax: check zero or empty entry before converting xarray entry#1321
Open
vfsci-bot[bot] wants to merge 1 commit intovfs.base.cifrom
Open
fs/dax: check zero or empty entry before converting xarray entry#1321vfsci-bot[bot] wants to merge 1 commit intovfs.base.cifrom
vfsci-bot[bot] wants to merge 1 commit intovfs.base.cifrom
Conversation
dax_associate_entry(), dax_disassociate_entry(), and dax_busy_page() call dax_to_folio(entry) before checking whether entry is a zero or empty xarray entry. That ordering is wrong because zero and empty entries are not folio entries. Commit 98c183a ("fs/dax: don't disassociate zero page entries") added guards in the associate and disassociate paths, but the guards still come after dax_to_folio(entry), and dax_busy_page() still has the same problem. Move the zero/empty checks before dax_to_folio(entry) in all three helpers. Fixes: 38607c6 ("fs/dax: properly refcount fs dax pages") Signed-off-by: Seunguk Shin <[email protected]> Reviewed-by: Jan Kara <[email protected]> Reviewed-by: Alistair Popple <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1089993
Submitter: Seunguk Shin
Version: 3
Patches: 1/1
Message-ID:
<[email protected]>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/[email protected]
Automated by ml2pr