Mixed bag of new tests for the 25.04 release #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
reviewed
Apr 30, 2025
hnez
requested changes
Apr 30, 2025
|
Its 25.04 and not 24.04 btw. How the time flies … |
SmithChart
changed the title
Uh, so true. I've changed the title. |
We have seen that the hostname can be "localhost" in cases where the EEPROM is not set. This should not happen in CI, since the TAC there should always have an EEPROM with useful TLV data. But let's check for it anyway.
hnez
requested changes
May 5, 2025
There was a problem hiding this comment.
I've found a few more small things, but in general I like the changes. The kernel output tests looks quite elegant now.
I've also found a typo in a commit message:
- test/labgrid: Log if the tests are retying
+ test/labgrid: Log if the tests are retryingBut that's it.
@hnez: Squashed your suggestions and fixed the typo in the commit message. |
hnez
approved these changes
May 5, 2025
We want some devices to have specific clock rates applied to them. This tests creates the infrastructure to check these rates. It also checks for the some first initial rates.
This test catches situations where some service is broken to the point that it does not start anymore. Co-authored-by: Leonard Göhrs <[email protected]>
We know that out kernel logs some warnings and errors on startup. These are accepted. With this test we make sure that the kernel only logs these messages and nothing new. Co-authored-by: Leonard Göhrs <[email protected]>
These tests are written in a way, that they can each block up to five minutes. Thus: Let's mark them as slow. And also add logging to the test case, so that during interactive testing the user gets some feedback on whats going on.
hnez
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the upcoming 25.04 release I have implemented tests from my backlog.