-
Notifications
You must be signed in to change notification settings - Fork 171
chore: Helmfile v1 compatibility [TOOLS][MINOR] #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success93 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 86cfd87 |
The GH action failed due to some leftover references to the old file extensions, but as these were fixed during the install, the job eventually completed successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it fixes the templating issues.
Do we also want to update the version in the Tools Docker image? |
Good point |
Once the compatibility has been verified, we might as well. Should we do it in this PR? |
|
📌 Summary
This PR renames files and updates the methods of passing arguments for forward compatibility with Helmfile v1.0.0. Changes are also compatible with pre-release versions and therefore only affect development environments for now.
Helmfile should not be updated in this PR since there are other conflicting changes pending.
🔍 Reviewer Notes
The following should be verified:
otomi
commandsvalidate-templates
ortemplate
work, wither with the most recent Helmfile releaes or settingHELMFILE_V1MODE=true
. Outputs should be equivalent in smoke test.🧹 Checklist