Skip to content

chore: Helmfile v1 compatibility [TOOLS][MINOR] #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 19, 2025
Merged

chore: Helmfile v1 compatibility [TOOLS][MINOR] #2136

merged 18 commits into from
May 19, 2025

Conversation

merll
Copy link
Contributor

@merll merll commented May 8, 2025

📌 Summary

This PR renames files and updates the methods of passing arguments for forward compatibility with Helmfile v1.0.0. Changes are also compatible with pre-release versions and therefore only affect development environments for now.

Helmfile should not be updated in this PR since there are other conflicting changes pending.

🔍 Reviewer Notes

The following should be verified:

  • Installing a cluster still works.
  • Local otomi commands validate-templates or template work, wither with the most recent Helmfile releaes or setting HELMFILE_V1MODE=true. Outputs should be equivalent in smoke test.

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

Copy link

github-actions bot commented May 8, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
41.37% (+0.21% 🔼)
774/1871
🔴 Branches
33.41% (+0.58% 🔼)
287/859
🔴 Functions
41% (+0.47% 🔼)
123/300
🔴 Lines
42.34% (+0.26% 🔼)
732/1729
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 common/hf.ts
6.59% (-0.55% 🔻)
0% 0%
7.5% (-0.64% 🔻)

Test suite run success

93 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 86cfd87

@merll merll requested review from CasLubbers and j-zimnowoda May 8, 2025 10:22
@merll
Copy link
Contributor Author

merll commented May 8, 2025

The GH action failed due to some leftover references to the old file extensions, but as these were fixed during the install, the job eventually completed successfully.

Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it fixes the templating issues.

@CasLubbers
Copy link
Contributor

Do we also want to update the version in the Tools Docker image?

@j-zimnowoda
Copy link
Contributor

Do we also want to update the version in the Tools Docker image?

Good point

@merll
Copy link
Contributor Author

merll commented May 16, 2025

Do we also want to update the version in the Tools Docker image?

Good point

Once the compatibility has been verified, we might as well. Should we do it in this PR?

@Ani1357 Ani1357 changed the title chore: Helmfile v1 compatibility chore: Helmfile v1 compatibility [TOOLS][MINOR] May 19, 2025
@Ani1357
Copy link
Contributor

Ani1357 commented May 19, 2025

  • Successfully tested compatibility in other branch helmfile_update.
  • While testing an issue was discovered and fixed(a4f871b) (duplicate key in harbor.gotmpl).
  • For the sake of not having multiple untracked PRs (without Jira ticket) I added my changes in this one.
  • Update the subject to include the trigger for generating an new apl-tools image with a minor version bump.
  • Merging this PR will create thew new image but the main build pipeline would probably fail because of the racing condition(the new image will not be ready probably). A re-run should solve this.

@j-zimnowoda j-zimnowoda merged commit 515ceca into main May 19, 2025
10 of 11 checks passed
@j-zimnowoda j-zimnowoda deleted the helmfile-v1 branch May 19, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants