Repository navigation
feat(instance): pass terminal window size from Web UI to PTY - #11
Merged
Merged
Conversation
- Use pty.Start() instead of script command to enable true PTY - Add Resize method to Manager for handling cols/rows updates - Parse resize messages in WebSocket handler - Frontend sends resize events with debouncing (100ms) This enables interactive programs (vim, less, etc.) to respond correctly when users resize the terminal in the Web UI.
Add three test cases: - TestResize_InvalidParams: validates empty/whitespace id and invalid cols/rows - TestResize_NotFound: validates error for nonexistent instance - TestResize_Success: creates real PTY and verifies resize works correctly
linletian
force-pushed
the
feature/passing-window-size
branch
from
March 11, 2026 13:59
5322079 to
68afeee
Compare
Ubuntu CI doesn't have zsh installed, causing TestResize_Success to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/creack/ptylibraryThis enables interactive programs (vim, less, tmux) to respond correctly when users resize the terminal in the Web UI.
Changes
go.mod/go.sum: Add pty dependencyinternal/instance/manager.go: Use pty.Start(), add Resize methodinternal/app/app.go: Parse and handle resize messagesinternal/ui/static/index.html: Send resize events from xterm.jsTest plan
vimand check :version output)