Skip to content

Content Type Option #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BkChoy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Content Type Option #30

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c68c2a
added http content type to options
BkChoy Jul 13, 2020
ddb21f7
formatting
BkChoy Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bridge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ type CallOpts struct {
QueryPassthrough bool `json:"queryPassthrough"`
Body string `json:"body"`
ExpectedCode int `json:"expectedCode"`
ContentType string `json:"ContentType"`
Copy link
Contributor

@jleeh jleeh Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting

}

// HTTPCall performs a basic http call with no options
Expand Down Expand Up @@ -341,7 +342,12 @@ func (h *Helper) HTTPCallRawWithOptsWithContext(ctx context.Context, method, url
if err != nil {
return nil, err
}
req.Header.Add("Content-Type", "application/json")

if (opts.ContentType == "") {
Copy link
Contributor

@jleeh jleeh Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, but personally prefer len(opts.ContentType) > 0 in Go, as it looks a bit cleaner rather than literal string matching.

req.Header.Add("Content-Type", "application/json")
} else {
req.Header.Add("Content-Type", opts.ContentType)
}

q := req.URL.Query()
if opts.QueryPassthrough {
Expand Down