Repository navigation
feat: opt-in SSSOM recipes around a thin overlay tool - #186
Draft
noelmcloughlin wants to merge 7 commits into
Draft
noelmcloughlin wants to merge 7 commits into
noelmcloughlin wants to merge 7 commits into
Conversation
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
Signed-off-by: noelmcloughlin <noel.mcloughlin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #177 and follows the specification posted on #163, which this PR could implement.
Draft: see mapping-commons/sssom-py#678
With
use_sssom(default: no) a generated project getssrc/<slug>/mappings/for curated*.sssom.tsvfiles, with a README and one example file when the example schema is chosen; addssssomandruamel.yamldev dependencies;scripts/overlay_sssom.py, usingsssom.parsers.parse_sssom_tableandSchemaView, to add mappings and--checkonly reports them; addssssom.justfilewithvalidate-sssom(the curated files),overlay-sssomandgen-sssom;just setupruns the overlay once before it generates the project, and the generated CI runsjust overlay-sssom --checkfor drift tracking.Tests: structural tests for the option on and off (default and
add_example: false), and an integration test that runsvalidate-sssom, sees--checkfail on a fresh project, applies the overlay, sees it pass and confirms a second run changes nothing.Closes #163.