Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): Upgrade tokio-rustls to 0.26 (#3419)" #3553

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sfleen
Copy link
Collaborator

@sfleen sfleen commented Jan 21, 2025

This reverts commit bb6e9b7.

This has been causing CI failures, reverting this change until those can be figured out.

@sfleen sfleen requested a review from a team as a code owner January 21, 2025 21:03
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.75%. Comparing base (96124bc) to head (be550c8).
Report is 738 commits behind head on main.

Files with missing lines Patch % Lines
linkerd/meshtls/rustls/src/creds/store.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
- Coverage   67.68%   66.75%   -0.93%     
==========================================
  Files         332      388      +56     
  Lines       15158    18135    +2977     
==========================================
+ Hits        10259    12106    +1847     
- Misses       4899     6029    +1130     
Files with missing lines Coverage Δ
linkerd/app/outbound/src/tls/logical/tests.rs 95.83% <100.00%> (ø)
linkerd/meshtls/rustls/src/client.rs 63.26% <100.00%> (ø)
linkerd/meshtls/rustls/src/creds.rs 81.08% <100.00%> (ø)
linkerd/meshtls/rustls/src/creds/receiver.rs 54.54% <ø> (ø)
linkerd/meshtls/rustls/src/creds/verify.rs 87.50% <100.00%> (ø)
linkerd/meshtls/rustls/src/server.rs 80.30% <100.00%> (ø)
linkerd/meshtls/rustls/src/creds/store.rs 90.90% <91.66%> (-1.52%) ⬇️

... and 167 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc0de7...be550c8. Read the comment docs.

@sfleen sfleen merged commit de25333 into linkerd:main Jan 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants