chore(cargo.toml): define more workspace dependencies #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit modifies the workspace manifest, defining prost and prost-types as common workspace dependencies. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
this commit modifies the workspace manifest, defining tonic and tonic-build as common workspace dependencies. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
this commit modifies the workspace manifest, defining bytes as a workspace dependency. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-dependents-become-workspace-dependencies
branch
from
ecc6ffa to
4d89b1e
Compare
cratelyn
added a commit
that referenced
this pull request
Dec 19, 2024
this commit modifies the workspace manifest, defining h2 as a workspace dependency. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
this commit modifies the workspace manifest, defining h2 as a workspace dependency. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
this is a small cosmetic tweak to the cargo workspace manifest. this defines the proxy api as a toml table, to help give us a more natural place to hang the (inert) example of a git dependency used in development. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-dependents-become-workspace-dependencies
branch
from
4d89b1e to
ce7a3a7
Compare
|
i've enabled auto-merge for this 🙂 |
sfleen
approved these changes
Dec 19, 2024
| @@ -32,6 +32,6 @@ regex = "1" | |||
| thiserror = "2" | |||
| tokio = { version = "1", features = ["rt"] } | |||
| tokio-stream = { version = "0.1", features = ["time", "sync"] } | |||
| tonic = { version = "0.10", default-features = false, features = ["prost"] } | |||
| tonic = { workspace = true, default-features = false, features = ["prost"] } | |||
There was a problem hiding this comment.
Not for this change, but we should consider moving the default-features/features up to the workspace level in the future, IIRC it helps with feature unification and can speed up incremental builds.
There was a problem hiding this comment.
that's a very good call. i would be on board with that!
cratelyn
deleted the
kate/hyper-1.x-dependents-become-workspace-dependencies
branch
cratelyn
added a commit
that referenced
this pull request
Dec 19, 2024
this commit modifies the workspace manifest, defining prost and prost-types as common workspace dependencies. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Dec 19, 2024
this commit modifies the workspace manifest, defining tonic and tonic-build as common workspace dependencies. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Dec 19, 2024
this commit modifies the workspace manifest, defining bytes as a workspace dependency. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Dec 19, 2024
this commit modifies the workspace manifest, defining h2 as a workspace dependency. no changes to the lockfile are made because this commit does not affect the dependency graph of the project. * linkerd/linkerd2#8733 Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in linkerd/linkerd2#8733, we're tracking work to upgrade to hyper 1.0.
when upgrading from 0.14 to 1.0, some related crates that depend on
hyper,http, andhttp-bodymust also be upgraded as well. in linkerd/linkerd2-proxy-api#421, as part of the upgrade to hyper 1.0 we additionally bump the following:h2: 0.3 -> 0.4http: 0.2 -> 1.2prost: 0.12 -> 0.13prost-types: 0.12 -> 0.13tonic: 0.10 -> 0.12tonic-build: 0.10 -> 0.12unlike linkerd2-proxy-api, the linkerd2-proxy repository is a particularly large cargo workspace. as a consequence of this, bumping these crates across our cargo workspace is a particularly noisy and involved change today. there are ~35 distinct package manifests that need to be changed!
to help ease development, future maintenance, and review of impending hyper upgrade changes, this branch consolidates all of the above into workspace dependencies. no changes to the lockfile are made because this branch does not affect the dependency graph of the project.
this follows from #3456 and #3466, which did this for
hyper,http, andhttp-body. for more information, see: