Handle zero-area and display: none cases #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asakusuma
force-pushed
the
isIntersecting
branch
2 times, most recently
from
2bd2352 to
80e1864
Compare
asakusuma
changed the title
Attempts to satsify the spec: https://www.w3.org/TR/intersection-observer/#update-intersection-observations-algo isIntersecting, non-zero area, and display:nonen are all related, so fixing in one swoop. Fixes: #93 #73 Related issues: w3c/IntersectionObserver#69 w3c/IntersectionObserver#222
asakusuma
force-pushed
the
isIntersecting
branch
from
80e1864 to
3042aa5
Compare
lynchbomb
requested changes
Jan 7, 2019
Move functions in index.ts into utils.ts
asakusuma
force-pushed
the
isIntersecting
branch
from
3e67bbb to
6386ddb
Compare
lynchbomb
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to satisfy the spec: https://www.w3.org/TR/intersection-observer/#update-intersection-observations-algo
isIntersecting, non-zero area, and display:nonen are all related, so fixing in one swoop.
Fixes:
#93
#73
Related issues:
w3c/IntersectionObserver#69
w3c/IntersectionObserver#222