Skip to content

Refresh category select page #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refresh category select page #50

wants to merge 1 commit into from

Conversation

@kahrendsen-li
Copy link
Contributor

@kahrendsen-li kahrendsen-li commented Dec 7, 2020 •
edited
Loading

Update style of category select page and add ability to toggle shake detection

Screenshot_1607373988

@kahrendsen-li kahrendsen-li requested a review from iliao58 December 7, 2020 16:15
iliao58
iliao58 reviewed Dec 10, 2020
View reviewed changes
Copy link

@iliao58 iliao58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should refactor to have a config object per fragment(or page) for ui features.

Base automatically changed from master to main March 1, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iliao58 iliao58 iliao58 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kahrendsen-li @iliao58