Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft for timestamping DLO generation and compaction. #182

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
package com.linkedin.openhouse.jobs.spark;

import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
import com.google.gson.reflect.TypeToken;
import com.linkedin.openhouse.datalayout.config.DataCompactionConfig;
import com.linkedin.openhouse.jobs.spark.state.StateManager;
import com.linkedin.openhouse.jobs.util.AppConstants;
import com.linkedin.openhouse.jobs.util.CompactionEvent;
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.api.common.Attributes;
import java.lang.reflect.Type;
import java.util.ArrayList;
import java.util.List;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.Option;
import org.apache.commons.lang.StringEscapeUtils;
import org.apache.commons.lang3.math.NumberUtils;
import org.apache.iceberg.actions.RewriteDataFiles;

Expand All @@ -24,6 +30,7 @@
@Slf4j
public class DataCompactionSparkApp extends BaseTableSparkApp {
private final DataCompactionConfig config;
public static final String DATA_LAYOUT_COMPACTION_PROPERTY_KEY = "write.data-layout.compaction";

protected DataCompactionSparkApp(
String jobId, StateManager stateManager, String fqtn, DataCompactionConfig config) {
Expand Down Expand Up @@ -58,6 +65,23 @@ protected void runInner(Operations ops) {
fileGroupRewriteResult.rewrittenDataFilesCount(),
fileGroupRewriteResult.rewrittenBytesCount());
}
// Add compaction timestamp to table properties.
CompactionEvent event =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teamurko can you confirm if this will be run after all partitions are compacted in Table or after each partition is compacted in a Table?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will run after compaction is done on the whole table

CompactionEvent.builder()
.compactionTimestamp(System.currentTimeMillis())
.addedDataFilesCount(result.addedDataFilesCount())
.rewrittenDataFilesCount(result.rewrittenDataFilesCount())
.rewrittenBytesCount(result.rewrittenBytesCount())
.build();
Gson gson = new GsonBuilder().create();
Type type = new TypeToken<CompactionEvent>() {}.getType();
ops.spark()
.sql(
String.format(
"ALTER TABLE %s SET TBLPROPERTIES ('%s' = '%s')",
ops.getTable(fqtn),
DATA_LAYOUT_COMPACTION_PROPERTY_KEY,
StringEscapeUtils.escapeJava(gson.toJson(event, type))));
Comment on lines +76 to +84
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but it's not related to the strategy, right? It's a compaction event. Should I push this functionality into a separate util?

METER
.counterBuilder(AppConstants.ADDED_DATA_FILE_COUNT)
.build()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.linkedin.openhouse.jobs.util;

import lombok.Builder;
import lombok.Data;

/** Compaction event to be logged as part of the table properties. */
@Data
@Builder
public class CompactionEvent {
private final long compactionTimestamp;
private final long addedDataFilesCount;
private final long rewrittenDataFilesCount;
private final long rewrittenBytesCount;
}
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ private Optional<DataLayoutStrategy> generateCompactionStrategy() {
return Optional.of(
DataLayoutStrategy.builder()
.config(configBuilder.build())
.computationTimestamp(System.currentTimeMillis())
.cost(computeGbHr)
.gain(reducedFileCount)
.score(reducedFileCountPerComputeGbHr)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
@Data
@Builder
public class DataLayoutStrategy {
private final long computationTimestamp;
anjagruenheid marked this conversation as resolved.
Show resolved Hide resolved
private final double score;
private final double entropy;
private final double cost;
Expand Down
Loading