catch duplicate entry errors and silently fail #492
Conversation
| _server.insert(aspect); | ||
| try { | ||
| _server.insert(aspect); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
can you only silent the known error:
catch (Exception e) {
Throwable cause = e.getCause();
if (cause != null && cause.getMessage().contains("Duplicate entry")) {
log.warn("Duplicate key error during insert. Exception: {}", e.toString());
} else {
throw e;
}
}
There was a problem hiding this comment.
LGTM! Please copy the stack trace info the PR description for tracking purposes. Thanks!
Error[Duplicate entry 'urn:li:mlFeatureAnchor:(urn:li:mlFeatureVersion:(urn:li:mlFeatur' for key 'metadata_aspect.PRIMARY']
at io.ebean.config.dbplatform.SqlCodeTranslator.translate(SqlCodeTranslator.java:46)
at io.ebean.config.dbplatform.DatabasePlatform.translate(DatabasePlatform.java:223)
at io.ebeaninternal.server.persist.dml.DmlBeanPersister.execute(DmlBeanPersister.java:83)
at io.ebeaninternal.server.persist.dml.DmlBeanPersister.insert(DmlBeanPersister.java:49)
at io.ebeaninternal.server.core.PersistRequestBean.executeInsert(PersistRequestBean.java:1295)
at io.ebeaninternal.server.core.PersistRequestBean.executeNow(PersistRequestBean.java:797)
at io.ebeaninternal.server.core.PersistRequestBean.executeNoBatch(PersistRequestBean.java:852)
at io.ebeaninternal.server.core.PersistRequestBean.executeOrQueue(PersistRequestBean.java:843)
at io.ebeaninternal.server.persist.DefaultPersister.insert(DefaultPersister.java:525)
at io.ebeaninternal.server.persist.DefaultPersister.insert(DefaultPersister.java:471)
at io.ebeaninternal.server.core.DefaultServer.insert(DefaultServer.java:1773)
at io.ebeaninternal.server.core.DefaultServer.insert(DefaultServer.java:1765)
at com.linkedin.metadata.dao.EbeanLocalDAO.insert(EbeanLocalDAO.java:855)
at com.linkedin.metadata.dao.EbeanLocalDAO.saveLatest(EbeanLocalDAO.java:627)
at com.linkedin.metadata.dao.BaseLocalDAO.addCommon(BaseLocalDAO.java:523)
Summary
Catch duplicate entry exceptions during server.insert() due to race conditions.
Log at WARN level.
Exceptions from before:
Testing Done
N/A
Checklist